Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Create separate CSV generation utils for CLI dashboard and extension #619

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Fix: Create separate CSV generation utils for CLI dashboard and extension #619

merged 2 commits into from
Jun 19, 2024

Conversation

ayushnirwal
Copy link
Contributor

@ayushnirwal ayushnirwal commented Apr 15, 2024 •
edited
Loading

Description

Cookie Table component was using the same utils in Extension and CLI. CLI does not get the data for "Priority", "Size" and "Blocking status". Thus a different utility was required. This PR adds that.

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

@ayushnirwal ayushnirwal changed the base branch from main to develop April 15, 2024 13:44
amovar18
amovar18 approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@amovar18 amovar18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mohdsayed mohdsayed merged commit 7fa686d into develop Jun 19, 2024
4 checks passed
@mohdsayed mohdsayed deleted the fix/cli-csv branch June 19, 2024 13:41
@mohdsayed mohdsayed added this to the v1.0.0 milestone Jun 24, 2024
@mohdsayed mohdsayed changed the title Fix: Separate CSV generation utils for CLI dashboard and Extension Fix: Create separate CSV generation utils for CLI dashboard and extension Jun 24, 2024
@mohdsayed mohdsayed mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohdsayed mohdsayed mohdsayed approved these changes

@amovar18 amovar18 amovar18 approved these changes

Assignees

@ayushnirwal ayushnirwal

Labels
None yet
Projects
None yet
Milestone
v0.9
Development

Successfully merging this pull request may close these issues.
3 participants
@ayushnirwal @mohdsayed @amovar18