Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Broken download button icon UI #636

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Fix: Broken download button icon UI #636

merged 3 commits into from
Apr 26, 2024

Conversation

mayan-000
Copy link
Collaborator

@mayan-000 mayan-000 commented Apr 22, 2024

Description

This PR fixes the distorted icon of download button when visiting back from subpages on landing pages.

Relevant Technical Choices

  • Changed the svg used as download button, as it had some issue of misalignment causing distortion.
  • Used icon from performance tab's download button.

Testing Instructions

  • Open cookie table, and then visit multiple subpages.
  • Come back to the landing page and icon should be consistent and no issue should be there.

Additional Information:

Screenshot/Screencast

Screen.Recording.2024-04-22.at.12.05.22.mov

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #624

@mayan-000 mayan-000 self-assigned this Apr 22, 2024
@mayan-000 mayan-000 marked this pull request as ready for review April 22, 2024 09:31
@mayan-000 mayan-000 requested a review from mohdsayed April 22, 2024 09:31
@mayan-000 mayan-000 changed the base branch from main to develop April 22, 2024 09:31
@mohdsayed mohdsayed added this to the v1.0.0 milestone Apr 26, 2024
@mohdsayed mohdsayed merged commit ee42182 into develop Apr 26, 2024
4 checks passed
@mohdsayed mohdsayed deleted the top-bar-icons branch April 26, 2024 07:16
@mohdsayed mohdsayed modified the milestones: v1.0.0, v0.8 May 2, 2024
@mohdsayed mohdsayed changed the title Fix: Broken download button icon Fix: Broken download button icon UI May 7, 2024
@mohdsayed mohdsayed mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Broken Download Button UI in DevTools Cookie Frame After Visiting Landing Page Subpages.
2 participants