Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update “Clear All” button render condition for filter chips #637

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

mayan-000
Copy link
Collaborator

@mayan-000 mayan-000 commented Apr 22, 2024

Description

This PR updates the condition for showing clear all button even when one filter is selected.
Earlier implementation included showing of clear all button only when more than one filter is selected.

Relevant Technical Choices

Testing Instructions

  • Open cookie table, and click on filter icon to open filter sidebar.
  • Dropdown any filter and select one value.
  • The chips will appear above table and clear all button will be visible for one filter also.

Additional Information:

Screenshot/Screencast

Screenshot 2024-04-22 at 12 59 39

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #621

@mayan-000 mayan-000 self-assigned this Apr 22, 2024
@mayan-000 mayan-000 linked an issue Apr 22, 2024 that may be closed by this pull request
@mayan-000 mayan-000 marked this pull request as ready for review April 22, 2024 09:32
@mayan-000 mayan-000 requested a review from mohdsayed April 22, 2024 09:32
@mohdsayed mohdsayed added this to the v1.0.0 milestone Apr 26, 2024
@mohdsayed mohdsayed merged commit 2c21f44 into develop Apr 26, 2024
4 checks passed
@mohdsayed mohdsayed deleted the clear-all-option branch April 26, 2024 07:14
@mohdsayed mohdsayed changed the title Refactor: Update Clear All button render condition Update Clear All button render condition May 7, 2024
@mohdsayed mohdsayed changed the title Update Clear All button render condition Update “Clear All” button render condition for filter chips May 7, 2024
@mohdsayed mohdsayed mentioned this pull request May 7, 2024
@maitreyie-chavan maitreyie-chavan modified the milestones: v1.0.0, v0.8 Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add "Clear all" option to filter settings
3 participants