Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: CLI output path relative to "out" directory. #638

Merged
merged 5 commits into from
Apr 26, 2024

Conversation

ayushnirwal
Copy link
Contributor

@ayushnirwal ayushnirwal commented Apr 23, 2024

Description

This PR updates the behavior of creating directories for analysis output. All relative paths will be relative to "out" directory.

Testing Instructions

Commands like npm run cli -- -u https://www.aljazeera.com/ -d foo or npm run cli -- -u https://www.aljazeera.com/ -d ./foo should make a directory relative to "out" directory, not the project root

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #626

@ayushnirwal ayushnirwal changed the base branch from main to develop April 23, 2024 07:37
@ayushnirwal ayushnirwal requested a review from mohdsayed April 23, 2024 13:23
@ayushnirwal ayushnirwal linked an issue Apr 24, 2024 that may be closed by this pull request
@mohdsayed mohdsayed added this to the v1.0.0 milestone Apr 26, 2024
@mohdsayed mohdsayed merged commit 1cf00de into develop Apr 26, 2024
4 checks passed
@mohdsayed mohdsayed deleted the enhancement/CLI-relative-path branch April 26, 2024 07:33
@mohdsayed mohdsayed modified the milestones: v1.0.0, v0.8 May 2, 2024
@mohdsayed mohdsayed mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI: Improve location target for decoupled CLI runs Add "Clear all" option to filter settings
2 participants