Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Revise method to keep service worker alive. #655

Merged
merged 6 commits into from
May 5, 2024

Conversation

amovar18
Copy link
Collaborator

@amovar18 amovar18 commented May 1, 2024

Description

This PR aims to add a better solution to keep the service worker alive than calling the chrome.storage.local.get.

Relevant Technical Choices

  • The service worker sends data to the content script at a setInterval of 10 seconds and keeps the service worker alive.

Testing Instructions

Additional Information:

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • [ ] This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

@amovar18 amovar18 self-assigned this May 1, 2024
@mohdsayed mohdsayed added this to the v1.0.0 milestone May 1, 2024
@amovar18 amovar18 changed the title Fix: Remove chrome.storage.local.get calls to keep service worker alive. Fix: Revise method to keep service worker alive. May 2, 2024
@amovar18 amovar18 requested review from mohdsayed and removed request for mohdsayed May 2, 2024 12:06
@mohdsayed mohdsayed modified the milestones: v1.0.0, v0.8 May 2, 2024
@amovar18 amovar18 force-pushed the fix/extension-crashing branch from 5af3472 to 4b26e21 Compare May 3, 2024 09:03
@mohdsayed mohdsayed merged commit a5561ab into develop May 5, 2024
4 checks passed
@mohdsayed mohdsayed deleted the fix/extension-crashing branch May 5, 2024 05:11
@mohdsayed mohdsayed mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants