Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Normalise blocking reason. #658

Merged
merged 1 commit into from
May 5, 2024
Merged

Fix: Normalise blocking reason. #658

merged 1 commit into from
May 5, 2024

Conversation

amovar18
Copy link
Collaborator

@amovar18 amovar18 commented May 2, 2024 •
edited
Loading

Description

This PR aims to normalise blocking reasons that are being added from different APIs.

Relevant Technical Choices

  • Essentially ExcludeThirdPartyPhaseout and ThirdPartyPhaseout are actually the same, the only difference is they come from different APIs.

Testing Instructions

  • Open a Chrome instance with a 3PCD-enabled flag.
  • Go to any website with 3rd party cookies.
  • You should see only ThirdPartyPhaseout as a blocking reason, not ExcludeThirdPartyPhaseout

Additional Information:

Screenshot/Screencast

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • [ ] This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

@amovar18 amovar18 self-assigned this May 2, 2024
@mohdsayed mohdsayed added this to the v0.8 milestone May 2, 2024
@amovar18 amovar18 marked this pull request as ready for review May 2, 2024 14:55
@mohdsayed mohdsayed merged commit fc3b0c6 into develop May 5, 2024
4 checks passed
@mohdsayed mohdsayed deleted the fix/remove-exclude-reasoning branch May 5, 2024 05:10
@mohdsayed mohdsayed mentioned this pull request May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohdsayed mohdsayed mohdsayed approved these changes

Assignees

@amovar18 amovar18

Labels
None yet
Projects
None yet
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.
2 participants
@amovar18 @mohdsayed