Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve landing pages UI #659

Merged
merged 8 commits into from
May 5, 2024
Merged

Improve landing pages UI #659

merged 8 commits into from
May 5, 2024

Conversation

mayan-000
Copy link
Collaborator

@mayan-000 mayan-000 commented May 3, 2024

Description

This PR adds code for updating the UI for the landing page with new content and styles.

Relevant Technical Choices

Testing Instructions

  • Clone this branch and build the extension.
  • Open PSAT panel and click on Site boundaries landing page.
  • The page should open with 4 tiles showing new content.
  • Click on any tile will open new page with docs related to the topic clicked.
  • Try same Tracking protection and Private advertising landing pages.

Additional Information:

Screenshot/Screencast

Screenshot 2024-05-03 at 12 40 26

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #

@mayan-000 mayan-000 self-assigned this May 3, 2024
@mayan-000 mayan-000 added this to the v0.8 milestone May 3, 2024
@mayan-000 mayan-000 requested a review from mohdsayed May 3, 2024 11:07
@mayan-000 mayan-000 marked this pull request as ready for review May 3, 2024 11:07
@mayan-000 mayan-000 requested a review from amovar18 May 3, 2024 11:07
@mohdsayed mohdsayed merged commit d9c0a35 into develop May 5, 2024
4 checks passed
@mohdsayed mohdsayed deleted the ref/landing-pages branch May 5, 2024 05:09
@gagan0123
Copy link
Collaborator

@mayan-000 @mohdsayed

Can we please use the UTM parameters, ?utm_source=psat&utm_medium=extension as added to other outbound links from the extension?

@gagan0123
Copy link
Collaborator

Ref: #506

@mohdsayed
Copy link
Collaborator

@mayan-000 @mohdsayed

Can we please use the UTM parameters, ?utm_source=psat&utm_medium=extension as added to other outbound links from the extension?

Done and pushed to develop

@mohdsayed mohdsayed changed the title Update landing pages UI Improve landing pages UI May 7, 2024
@mohdsayed mohdsayed mentioned this pull request May 7, 2024
@gagan0123
Copy link
Collaborator

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants