Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reCaptcha from library detection #670

Merged
merged 2 commits into from
May 8, 2024
Merged

Conversation

mayan-000
Copy link
Collaborator

@mayan-000 mayan-000 commented May 8, 2024

Description

This PR handles removal of reCaptcha from library detection package.

  • Remove the callbacks to reCaptcha files.
  • Remove files containing code related to reCaptcha detection.

Relevant Technical Choices

Testing Instructions

  • Navigate to site https://online.1c.ru/
  • Open PSAT panel and navigate to cookies landing page.
  • Move to known breakages section.
  • The section should be empty with no libraries detected text.
  • Now do same steps with developbranch/0.70v and compare.

Additional Information:

Screenshot/Screencast

Screenshot 2024-05-08 at 11 29 38

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #

@mohdsayed mohdsayed marked this pull request as ready for review May 8, 2024 06:52
@mohdsayed mohdsayed added this to the v0.8 milestone May 8, 2024
@mohdsayed mohdsayed merged commit c8a2d04 into develop May 8, 2024
4 checks passed
@mohdsayed mohdsayed deleted the remove-recaptcha branch May 8, 2024 06:53
@amovar18 amovar18 mentioned this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants