Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Zero cookie issue. #671

Merged
merged 1 commit into from
May 8, 2024
Merged

Fix: Zero cookie issue. #671

merged 1 commit into from
May 8, 2024

Conversation

amovar18
Copy link
Collaborator

@amovar18 amovar18 commented May 8, 2024 •
edited
Loading

Description

  • This issue fixes the zero cookie issue that occurs randomly while doing cookie analysis.

Relevant Technical Choices

  • Move setInterval from service worker to new objectCreation of SynchnorousCookieStore.

Testing Instructions

Additional Information:

Screenshot/Screencast

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

@amovar18
Fix zero cookie issue.
52c2824 
Move setInterval to new objectCreation of SynchnorousCookieStore.
@amovar18 amovar18 marked this pull request as ready for review May 8, 2024 07:32
@mohdsayed mohdsayed added this to the v0.8 milestone May 8, 2024
@mohdsayed mohdsayed merged commit 872ebfc into develop May 8, 2024
4 checks passed
@mohdsayed mohdsayed deleted the fix/zero-cookie-issue branch May 8, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohdsayed mohdsayed mohdsayed approved these changes

Assignees

@amovar18 amovar18

Labels
None yet
Projects
None yet
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.
2 participants
@amovar18 @mohdsayed