Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Inconsistent highlighting on livemint.com #683

Merged
merged 2 commits into from
May 30, 2024
Merged

Fix: Inconsistent highlighting on livemint.com #683

merged 2 commits into from
May 30, 2024

Conversation

ayushnirwal
Copy link
Contributor

@ayushnirwal ayushnirwal commented May 20, 2024 •
edited by mohdsayed
Loading

Description

This PR fixes some cookies not being highlighted on livemint.com

Relevant Technical Choices

  1. isBlocked is recalculated in parseNetworkDataToCookieData

Testing Instructions

  1. Run npm run cli -- -u https://livemint.com/
  2. Open CLI Dashboard and the ppid cookie should be highlighted

Screenshot/Screencast

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • [ ] This code is covered by unit tests to verify that it works as intended. NA
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #680

@ayushnirwal ayushnirwal added this to the v1.0.0 milestone May 20, 2024
@ayushnirwal ayushnirwal self-assigned this May 20, 2024
@maitreyie-chavan maitreyie-chavan added the bug Something isn't working label May 22, 2024
@gagan0123 gagan0123 changed the base branch from main to develop May 27, 2024 11:58
@mohdsayed mohdsayed merged commit cbb862d into develop May 30, 2024
4 checks passed
@mohdsayed mohdsayed deleted the fix/highlight-issues branch May 30, 2024 07:00
@mohdsayed mohdsayed changed the title Fix: inconsistent highlighting on livemint.com Fix: Inconsistent highlighting on livemint.com Jun 24, 2024
@mohdsayed mohdsayed mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohdsayed mohdsayed mohdsayed approved these changes

@mayan-000 mayan-000 Awaiting requested review from mayan-000

Assignees

@ayushnirwal ayushnirwal

Labels
bug Something isn't working CLI
Projects
None yet
Milestone
v0.9
Development

Successfully merging this pull request may close these issues.

CLI: Inconsistent Highlighting for Blocked Cookies in Cookie Issues section
4 participants
@ayushnirwal @mohdsayed @maitreyie-chavan @mayan-000