Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Navigate from PSAT to network panel #685

Merged
merged 4 commits into from
May 23, 2024

Conversation

mayan-000
Copy link
Collaborator

@mayan-000 mayan-000 commented May 22, 2024

Description

This PR adds an API that will allow navigation to the network panel from PSAT.
This API is available in the Chrome version 125.
On old Chrome versions, the old functionality of copying network filter string from context menu will continue.

Relevant Technical Choices

Testing Instructions

  • Open Chrome v125, and install PSAT.
  • Start analyzing a tab, and move to the cookie table.
  • Right-click on any row and the dialog box should open.
  • The first item should say 'Show Requests With This Cookie', click on it will open the network panel with filter inside the input bar.
  • The rows in network will be filtered according to the cookie name and domain provided.
  • Try the same Chrome v124 or below now, this should not open the network panel and continue the old functionality copying filter to the clipboard.

Additional Information:

Screenshot/Screencast

Screen.Recording.2024-05-23.at.11.36.34.mov

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #293

@mayan-000 mayan-000 changed the base branch from main to develop May 22, 2024 11:26
@mayan-000 mayan-000 self-assigned this May 23, 2024
@mayan-000 mayan-000 marked this pull request as ready for review May 23, 2024 06:10
@mayan-000 mayan-000 requested review from mohdsayed and amovar18 May 23, 2024 06:10
@mohdsayed mohdsayed added this to the v1.0.0 milestone May 23, 2024
@mohdsayed mohdsayed added the enhancement New feature or request label May 23, 2024
@mohdsayed mohdsayed merged commit cb2fcc8 into develop May 23, 2024
4 checks passed
@mohdsayed mohdsayed deleted the feat/network-panel-navigation branch May 23, 2024 22:59
@mohdsayed mohdsayed mentioned this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigate from cookie to corresponding network request
2 participants