-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Publish packages on the NPM registry #698
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configure tsconfig for publishing.
…l into feat/npm-package-publishing
Publish library-detection.
…l into feat/npm-package-publishing
…l into feat/npm-package-publishing
Please mention a test instruction stating to install the command globally and test that This PR may also fix the spawn error issue mentioned in issue #677 's in newer versions of Node since we are not spawning a new server to serve CLI dashboard. Let's test that too. |
@amovar18 Please resolve conflicts |
…l into feat/npm-package-publishing
mohdsayed
approved these changes
Jun 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to publish the following packages on NPM registry:
analysis-utils
cli-dashboard
cli
common
design-system
i18n
library-detection
Relevant Technical Choices
packagename:build
Testing Instructions
This PR has to be tested in 2 different ways:
PSAT
is installed in a project:npm i
.coreutils
which is not available on OSX so its better to install coreutils usingbrew install coreutils
.npm run local-registry:start
.npm run publish:all:local
this will build all the packages that need to be published.npm run cli
command and check the extension if it works properly.http://localhost:4873
you will see all the packages that have been published.npm init
.npm install @ps-analysis-tool/cli --registry=http://localhost:4873
.npx psat
command.npm run local-registry:start
runnpm run local-registry:stop
.PSAT
is installed globally:npm i @ps-analysis-tool/cli @ps-analysis-tool/cli-dashboard -g --registry=http://localhost:4873
.psat
command.Screenshot/Screencast
Checklist
[ ] This code is covered by unit tests to verify that it works as intended.NAFixes #589