Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add website hostname as prefix to cookie table CSV #700

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

mayan-000
Copy link
Collaborator

@mayan-000 mayan-000 commented May 31, 2024

Description

This PR adds code to add hostname as a prefix to the cookie table CSV.

Relevant Technical Choices

Testing Instructions

  • Open the PSAT panel and open the cookie table.
  • Click on the download icon beside the search bar.
  • A file should be downloaded and the file name should include hostname as a prefix.
  • For eg. website is https://livemint.com, the file should be www-livemint-com-report.csv

Additional Information:

Screenshot/Screencast

Screenshot 2024-05-31 at 16 51 30

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #688

@mayan-000 mayan-000 self-assigned this Jun 3, 2024
@mayan-000 mayan-000 requested a review from mohdsayed June 3, 2024 11:11
@mayan-000 mayan-000 marked this pull request as ready for review June 3, 2024 11:11
@mohdsayed mohdsayed added this to the v1.0.0 milestone Jun 5, 2024
@mohdsayed mohdsayed merged commit 0ce7228 into develop Jun 5, 2024
4 checks passed
@mohdsayed mohdsayed deleted the prefix-csv-file branch June 5, 2024 15:39
@mohdsayed mohdsayed mentioned this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants