Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily remove storybook package #702

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

mohdsayed
Copy link
Collaborator

@mohdsayed mohdsayed commented Jun 4, 2024

Description

The Storybook package has been found to contain four high-severity vulnerabilities. As Storybook is not currently a hard dependency for PSAT, we're temporarily removing Storybook package dependencies from package.json. This will be in place until the issues are fixed in an upcoming Storybook version or we find a solution.

Relevant Technical Choices

Testing Instructions

  • Run npm audit report.
  • It should show found 0 vulnerabilities

Additional Information:

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • [ ] This code is covered by unit tests to verify that it works as intended. NA
  • [ ] The QA of this PR is done by a member of the QA team (to be checked by QA). NA

Fixes #701

@mohdsayed mohdsayed self-assigned this Jun 4, 2024
@mohdsayed mohdsayed requested review from amovar18 and mayan-000 June 4, 2024 04:28
@mohdsayed mohdsayed merged commit 9093d5a into main Jun 4, 2024
3 checks passed
@mohdsayed mohdsayed deleted the fix/storybook-vulnerabilities branch June 4, 2024 04:36
@mohdsayed mohdsayed mentioned this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 High Severity Vulnerabilities with npm audit
2 participants