Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Conditionally use I18n.getMessage function inside InfoCard #720

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

mayan-000
Copy link
Collaborator

@mayan-000 mayan-000 commented Jun 24, 2024

Description

This PR adds the useI18n key value inside InfoCard so as not to use getMessage for non-translated strings.

Relevant Technical Choices

Testing Instructions

  • Configure the system for a locale other than English and open PSAT.
  • Navigate to the Protected Audience landing page, the text should be visible in English without any breakage.
  • Now compare the same with the develop branch.

Additional Information:

Screenshot/Screencast

Screenshot 2024-06-24 at 11 25 03

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #

@mayan-000 mayan-000 self-assigned this Jun 24, 2024
@mayan-000 mayan-000 requested a review from mohdsayed June 24, 2024 06:45
@mayan-000 mayan-000 marked this pull request as ready for review June 24, 2024 06:45
@mohdsayed mohdsayed added this to the v1.0.0 milestone Jun 24, 2024
@mohdsayed mohdsayed merged commit df1c013 into develop Jun 24, 2024
4 checks passed
@mohdsayed mohdsayed deleted the fix/info-cards branch June 24, 2024 08:09
@mohdsayed mohdsayed mentioned this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants