Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Update package scope name to @google-psat #725

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Refactor: Update package scope name to @google-psat #725

merged 1 commit into from
Jun 25, 2024

Conversation

mohdsayed
Copy link
Collaborator

@mohdsayed mohdsayed commented Jun 25, 2024 •
edited
Loading

Description

Update npm package scope name from @ps-analysis-tool to @google-psat to be published on npm registry.

Relevant Technical Choices

Testing Instructions

  • Ensure the name change doesn't have any effect on the extension.
  • Ensure CLI commands are working as expected.

Additional Information:

Screenshot/Screencast

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • [ ] This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #

@mohdsayed mohdsayed added this to the v1.0.0 milestone Jun 25, 2024
@mohdsayed mohdsayed self-assigned this Jun 25, 2024
@mohdsayed mohdsayed marked this pull request as ready for review June 25, 2024 10:24
@mohdsayed mohdsayed mentioned this pull request Jun 25, 2024
Merged
amovar18
amovar18 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@amovar18 amovar18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mohdsayed mohdsayed merged commit 9a314ab into develop Jun 25, 2024
4 checks passed
@mohdsayed mohdsayed deleted the ref/update-scope-name branch June 25, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amovar18 amovar18 amovar18 approved these changes

@ayushnirwal ayushnirwal Awaiting requested review from ayushnirwal

@mayan-000 mayan-000 Awaiting requested review from mayan-000

Assignees

@mohdsayed mohdsayed

Labels
None yet
Projects
None yet
Milestone
v0.9
Development

Successfully merging this pull request may close these issues.
2 participants
@mohdsayed @amovar18