Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Paths for CLI to work on global as well as local installation. #727

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

amovar18
Copy link
Collaborator

@amovar18 amovar18 commented Jun 26, 2024

Description

This PR aims to make CLI work when its published on NPM as well as when the repository is cloned.

Relevant Technical Choices

  • Use different paths to get the CLI dependencies.

Testing Instructions

For local installation:

  • Clone this branch.
  • Go to terminal and run npm run build-cli.
  • Now run npm run cli https://natgeo.com
  • You should be able to see the report.

For global installation:

  • Go to terminal and run npm run local-registry:start && npm run publish:all:local.
  • Then open new terminal instance ther run npm i -g @google-psat/cli && psat https://bbc.com.
  • You should be able to see the report.

Additional Information:

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

@amovar18 amovar18 added the enhancement New feature or request label Jun 26, 2024
@amovar18 amovar18 self-assigned this Jun 26, 2024
@amovar18 amovar18 marked this pull request as ready for review June 26, 2024 06:02
@mohdsayed mohdsayed merged commit fa34dfc into develop Jun 26, 2024
4 checks passed
@mohdsayed mohdsayed added this to the v1.0.0 milestone Jun 26, 2024
@mohdsayed mohdsayed changed the title Fix paths for cli to work on global as well as local installation. Fix: Paths for CLI to work on global as well as local installation. Jun 26, 2024
@mohdsayed mohdsayed mentioned this pull request Jun 26, 2024
@mohdsayed mohdsayed deleted the feat/cli-on-npm branch July 3, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants