Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Fix missing frame key in the page frames hash map #728

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

ayushnirwal
Copy link
Contributor

@ayushnirwal ayushnirwal commented Jun 26, 2024

Description

This PR fixes an intermittently occurring error bug when analyzing sites.
Screenshot 2024-06-25 at 7 53 54 AM

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • [ ] This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

@mohdsayed mohdsayed added this to the v1.0.0 milestone Jun 26, 2024
@mohdsayed mohdsayed merged commit 4fe456b into develop Jun 26, 2024
4 checks passed
@mohdsayed mohdsayed deleted the fix/missing-frame-error branch June 26, 2024 11:03
@mohdsayed mohdsayed changed the title CLI: Fix missing frame key in the page frames Hashmap CLI: Fix missing frame key in the page frames hashmap Jun 26, 2024
@mohdsayed mohdsayed changed the title CLI: Fix missing frame key in the page frames hashmap CLI: Fix missing frame key in the page frames hash map Jun 26, 2024
@mohdsayed mohdsayed mentioned this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants