Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add "Private Aggregation" panel #746

Merged
merged 9 commits into from
Jul 18, 2024

Conversation

mohdsayed
Copy link
Collaborator

@mohdsayed mohdsayed commented Jul 8, 2024

Description

Private Aggregation panel under Private Advertising section

Relevant Technical Choices

  • Add details for "Private Aggregation" in data/PSInfo.json file.
  • Create new component for Private Aggregation.

Testing Instructions

  • In the PSAT extension, open “Private Advertising” section and test if “Private Aggregation” section is added.
  • Ensure it has content and all links are working as expected

Additional Information:

Screenshot/Screencast

image

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • [ ] This code is covered by unit tests to verify that it works as intended. NA
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #740

@mohdsayed mohdsayed self-assigned this Jul 8, 2024
@mohdsayed mohdsayed added this to the v1.0.0 milestone Jul 8, 2024
@mohdsayed mohdsayed marked this pull request as ready for review July 15, 2024 12:26
@mohdsayed mohdsayed requested review from mayan-000 and amovar18 July 15, 2024 12:26
Copy link
Collaborator

@amovar18 amovar18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mohdsayed mohdsayed merged commit d8321fb into develop Jul 18, 2024
4 checks passed
@mohdsayed mohdsayed deleted the feat/private-aggregation-panel branch July 18, 2024 06:31
@mohdsayed mohdsayed mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants