Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Remove blocking status and mapping columns from cookies table #748

Merged
merged 9 commits into from
Jul 18, 2024

Conversation

mohdsayed
Copy link
Collaborator

@mohdsayed mohdsayed commented Jul 9, 2024

Description

Remove "Blocking Status" and "Mapping" columns from cookies table as they are no longer being used and were be removed in the next version

Relevant Technical Choices

  • Remove "Blocking Status" and "Mapping" columns from useCookieListing hook.
  • Remove OrphanedUnMappedInfoDisplay component which was used for mapping column.
  • Remove all translations from message.json files.

Testing Instructions

  • Open the cookies table, right-click on the column title to show hidden columns, and check if both columns appear.

Additional Information:

They were originally added because of the mixed API usage. Some cookies that CDP was able to catch (outbound blocked request cookies) could not be caught by the webRequest API.
Due to issues with CDP, we were unsure if the blocking status and mapping problem would resolve. In our testing, we didn't find any blocked cookies. However, since we and QA test a wide variety of websites, we decided to keep these columns for v0.9 in case anyone reports issues with blocking status and cookie mapping information.

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
    - [ ] This code is covered by unit tests to verify that it works as intended. NA
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #

@mohdsayed mohdsayed added this to the v1.0.0 milestone Jul 9, 2024
@mohdsayed mohdsayed self-assigned this Jul 9, 2024
@mohdsayed mohdsayed changed the title Chore: Remove blocking status column from cookies table Chore: Remove blocking status and mapping columns from cookies table Jul 9, 2024
@mohdsayed mohdsayed marked this pull request as ready for review July 9, 2024 07:05
@mohdsayed mohdsayed requested review from amovar18 and mayan-000 July 18, 2024 12:12
Copy link
Collaborator

@amovar18 amovar18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mohdsayed mohdsayed merged commit 181273b into develop Jul 18, 2024
4 checks passed
@mohdsayed mohdsayed deleted the chore/remove-unused-column branch July 18, 2024 13:40
@mohdsayed mohdsayed mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants