Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use onCommittedNavigation Listener instead of onTabUpdated #755

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

amovar18
Copy link
Collaborator

@amovar18 amovar18 commented Jul 10, 2024

Description

On some sites it was noticed the tab doesnt reload but due to ads the tab was moved to loading state. This PR aims to use onCommitted listener from chrome.webNavigation which fixes the resetting of cookie stats issue.

Relevant Technical Choices

  • Use onCommitted listener from chrome.webNavigation instead of chrome.tabs.onUpdated.

Testing Instructions

  • Clone this branch.
  • In the terminal run npm run ext:build
  • Now in the browser open beebom.com
  • Go to any article and keep on scrolling you should see that the cookie stats do not reset now.

Additional Information:

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

@amovar18 amovar18 self-assigned this Jul 10, 2024
@amovar18 amovar18 marked this pull request as ready for review July 11, 2024 07:11
@amovar18 amovar18 requested review from mohdsayed and mayan-000 July 11, 2024 07:11
@mohdsayed mohdsayed added this to the v1.0.0 milestone Jul 11, 2024
@mohdsayed mohdsayed added the bug Something isn't working label Jul 11, 2024
@mohdsayed mohdsayed merged commit 425393a into develop Jul 11, 2024
4 checks passed
@mohdsayed mohdsayed deleted the fix/pseudo-tab-refresh branch July 11, 2024 07:14
@mohdsayed mohdsayed mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants