Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Setup report package development configurations #756

Merged
merged 5 commits into from
Jul 11, 2024

Conversation

mohdsayed
Copy link
Collaborator

@mohdsayed mohdsayed commented Jul 11, 2024

Description

It's difficult to work on report file as it requires the following steps.

  1. Make changes to the file
  2. Run cli-dashboard build
  3. Analyze a website and wait for the file to open.
  4. Download the report to view changes.

Relevant Technical Choices

  • Set up a separate webpack configuration.
  • Reuse PSAT_DATA object from test to feed the report app.
  • Conditionally set window.PSAT_DATA for development env.
  • User webpack server to view file

Testing Instructions

Run npm run report:dev to see if it opens report file in a dev server.

Additional Information:

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • [ ] This code is covered by unit tests to verify that it works as intended. NA
  • [ ] The QA of this PR is done by a member of the QA team (to be checked by QA). NA

Fixes #

@mohdsayed mohdsayed added this to the v1.0.0 milestone Jul 11, 2024
@mohdsayed mohdsayed requested review from amovar18 and mayan-000 July 11, 2024 11:26
Copy link
Collaborator

@amovar18 amovar18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mohdsayed mohdsayed merged commit 81fe601 into develop Jul 11, 2024
4 checks passed
@mohdsayed mohdsayed deleted the chrome/report-dev-setup branch July 11, 2024 11:30
@mohdsayed mohdsayed mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants