-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Performance issues in chrome PSAT extension. #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add deep-object-diff to library-detection.
…l into fix/ui-performance
…ead of onUpdated listener.
use oncompleted listener
…l into fix/ui-performance
…nalysis-tool into fix/ui-performance
mohdsayed
approved these changes
Jul 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
dailymail.co.uk
it was seen that the PSAT extension consumed more amount of CPU when extension was opened. This is an effort to reduce the CPU consumption being done by PSAT UI.Relevant Technical Choices
chrome.webNavigation.onCompleted
listener instead ofchrome.tabs.onUpdated
Testing Instructions
Additional Information:
Screenshot/Screencast
Checklist
[ ] This code is covered by unit tests to verify that it works as intended.