Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Performance issues in chrome PSAT extension. #762

Merged
merged 17 commits into from
Jul 22, 2024

Conversation

amovar18
Copy link
Collaborator

@amovar18 amovar18 commented Jul 19, 2024

Description

In dailymail.co.uk it was seen that the PSAT extension consumed more amount of CPU when extension was opened. This is an effort to reduce the CPU consumption being done by PSAT UI.

Relevant Technical Choices

  • Only change state if any value in cookie has changed.
  • Use deep object diff to calculate diff between objects.
  • Use chrome.webNavigation.onCompleted listener instead of chrome.tabs.onUpdated

Testing Instructions

Additional Information:

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • [ ] This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

@amovar18 amovar18 self-assigned this Jul 19, 2024
@amovar18 amovar18 marked this pull request as ready for review July 22, 2024 05:44
@amovar18 amovar18 requested review from mohdsayed and mayan-000 July 22, 2024 05:44
@mohdsayed mohdsayed merged commit b2c4d58 into develop Jul 22, 2024
4 checks passed
@mohdsayed mohdsayed deleted the fix/ui-performance branch July 22, 2024 05:52
@mohdsayed mohdsayed mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants