Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Report generation #766

Merged
merged 17 commits into from
Jul 24, 2024
Merged

Fix: Report generation #766

merged 17 commits into from
Jul 24, 2024

Conversation

amovar18
Copy link
Collaborator

@amovar18 amovar18 commented Jul 22, 2024

Description

After adding global filtering in the CLI and the extension. It didnt make a point to download the dashboard landing page. So now if user downloads report from anywhere it will download the full report with the relevant data.

Relevant Technical Choices

  • Remove the usage of report package.

Testing Instructions

For CLI:

  • Clone this branch. In the terminal run npm run build:all.
  • Now in CLI run npm run cli -- -u https://bbc.com
  • Open the report and download the report from the CLI dashboard.
  • It should open a similar report to the CLI-dashboard.

For extension:

  • Open the browser and install the PSAT extension zip.
  • Download the report from the browser.
  • Then download the report again from the dashboard, it should be similar to the report downloaded.

Additional Information:

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

@amovar18 amovar18 changed the base branch from main to develop July 22, 2024 10:18
@amovar18 amovar18 marked this pull request as ready for review July 24, 2024 07:45
@amovar18 amovar18 requested review from mayan-000 and mohdsayed July 24, 2024 07:45
Copy link
Collaborator

@mohdsayed mohdsayed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mohdsayed mohdsayed merged commit d4cbda3 into develop Jul 24, 2024
4 checks passed
@mohdsayed mohdsayed deleted the fix/report-generation branch July 24, 2024 09:28
@mohdsayed mohdsayed mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants