Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add tabs navigation inside landing page #808

Merged
merged 8 commits into from
Aug 16, 2024
Merged

Conversation

mayan-000
Copy link
Collaborator

@mayan-000 mayan-000 commented Aug 16, 2024

Description

This PR adds tabs based navigation inside landing pages.

Relevant Technical Choices

  • The Tab and Shift + Tab keys can also be used for navigation inside the landing page.

Testing Instructions

  • Open the PSAT panel and navigate to RWS.
  • Once opened, tabs-based UI should be visible.
  • Using Tab and Shift + Tab will also respond to navigation.

Additional Information:

Screenshot/Screencast

Screenshot 2024-08-16 at 15 07 24

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #780

@mayan-000 mayan-000 self-assigned this Aug 16, 2024
@mayan-000 mayan-000 marked this pull request as ready for review August 16, 2024 09:38
Copy link
Collaborator

@mohdsayed mohdsayed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mohdsayed mohdsayed added this to the v1.0 milestone Aug 16, 2024
@mohdsayed mohdsayed merged commit 34eb5d0 into develop Aug 16, 2024
6 checks passed
@mohdsayed mohdsayed deleted the feat/tabs branch August 17, 2024 05:47
@gagan0123 gagan0123 modified the milestones: v1.0, v0.11 Aug 30, 2024
@milindmore22 milindmore22 mentioned this pull request Sep 2, 2024
32 tasks
@mohdsayed mohdsayed mentioned this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension: Feature separation and Feature navigation widget for each PSAT sections
3 participants