-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Create PSAT landing page and dashboard #827
Conversation
@pavanpatil1 Ready for QA |
Screen.Recording.2024-09-06.at.1.55.50.PM.mov |
It's the same button used in dashboard. We wouldn't want to use the blue button.
Good catch! Fixed
That makes sense, updated to use the same design from landing pages.
I had initially kept it in the beginning; however, it was later decided that we wanted to keep it after “Privacy Sandbox”.
Fixed
Fixed
Fixed. |
We are not matching these boxes design from the other landing pages, or else it should have been styled very differently. |
2024-09-09.12-21-45.mov |
When the user clicks on the cookie table on the dashboard before running an audit, the link goes to the cookie landing page. Should we redirect the user to the cookie table after the user presses "analyses page"? 2024-09-09.12-59-58.mov |
…ysis-tool into feat/psat-landing-page
… two and one-column layout
sidebarKey: SIDEBAR_ITEMS_KEYS.PROTECTED_AUDIENCE, | ||
}, | ||
{ | ||
name: 'Cookies', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The translation is available for most names or descriptions, I18n can be used.
packages/extension/src/view/devtools/components/dashboard/constants.ts
Outdated
Show resolved
Hide resolved
Fixed
I think instead of that, if the table is not available, that button should not be displayed, pushed an update for it. |
Description
Redesign the PSAT landing page and add a dashboard with pinned items and features for easy navigation.
Relevant Technical Choices
Testing Instructions
Additional Information:
Screenshot/Screencast
Landing Page
Dashboard
Checklist
[ ] This code is covered by unit tests to verify that it works as intended.NAFixes #799