Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Update order of PAT Section components #831

Merged
merged 4 commits into from
Sep 6, 2024

Conversation

amovar18
Copy link
Collaborator

@amovar18 amovar18 commented Sep 3, 2024

Description

This PR aims to reorder the items in the sidebar.

Relevant Technical Choices

Testing Instructions

  • Clone the branch.
  • In the terminal run npm i and then run npm run build:ext.
  • You should see the order in PAT section as follows:
  1. Topics
  2. Protected Audience
  3. Attribution Reporting
  4. Private Aggregation

Additional Information:

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #824

@amovar18 amovar18 added this to the v0.11 milestone Sep 3, 2024
@amovar18 amovar18 self-assigned this Sep 3, 2024
@fellyph
Copy link
Collaborator

fellyph commented Sep 3, 2024

@amovar18 I think the items should be consistent between the sidebar and landing page:

Screenshot 2024-09-03 at 13 46 22

@fellyph
Copy link
Collaborator

fellyph commented Sep 3, 2024

I have checked the latest changes and all good now:

Screenshot 2024-09-03 at 13 54 31

@pavanpatil1
Copy link
Collaborator

Looks good @amovar18.

I have a question: The page displays 'Attribution Reporting' correctly, but the navigation label only shows 'Attribution.' Shouldn't it also be labeled 'Attribution Reporting'?

Screenshot 2024-09-03 at 8 21 37 PM

@amovar18 amovar18 linked an issue Sep 4, 2024 that may be closed by this pull request
@amovar18 amovar18 changed the base branch from develop to release/v0.11.0 September 5, 2024 08:02
Copy link
Collaborator

@mohdsayed mohdsayed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mohdsayed mohdsayed merged commit a03bf15 into release/v0.11.0 Sep 6, 2024
4 checks passed
@mohdsayed mohdsayed deleted the feat/reorder-tabs branch September 6, 2024 05:49
@mohdsayed mohdsayed mentioned this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update order of PAT Section components
5 participants