Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements: Updates to topics EE #884

Merged
merged 21 commits into from
Dec 11, 2024
Merged

Conversation

mayan-000
Copy link
Collaborator

@mayan-000 mayan-000 commented Dec 6, 2024

Description

This PR makes UI/UX enhancements on topics EE alongside enabling interlinking to topics tax tree.

  • Hovering over the domain circle should show the info box.
  • Make domains or small circles clickable and highlight rows that have the same domains.
  • Use same circle UI for “Observed-by context domains:”
  • Internal link from Topics EE to Taxonomy tree.
  • Remove the topic from the top of the node.
  • Do not connect lines by default, connect as the user travels through nodes.
  • A website can have multiple topics, add such examples in the explorable explanation.

Relevant Technical Choices

Testing Instructions

  • Open PSAT, navigate the topics panel, and open explorable explanations.
    The animation should start. After a few visits, pause it, and now hover over any circle. The info box should appear and remain there.
  • Now click on the small circles, it should highlight the table cells for that circle's value.
  • In the table click on the topic name, it should open the taxonomy tree in an expanded view.
  • Now come navigate back to EE, it should be the same as navigated earlier.

Additional Information:

Screenshot/Screencast

Screen.Recording.2024-12-09.at.13.38.26.mov

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #856

@mohdsayed mohdsayed added this to the v1.0 milestone Dec 11, 2024
@mayan-000 mayan-000 marked this pull request as ready for review December 11, 2024 13:22
@mohdsayed
Copy link
Collaborator

Issues/improvements to fixed for the next PR

  • Clicking on the topic should scroll down to the taxonomy.
  • Sometimes white background appears behind nodes.
  • Change cursor to pointer for clickable elements.

Copy link
Collaborator

@amovar18 amovar18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mohdsayed mohdsayed merged commit f247891 into develop Dec 11, 2024
6 checks passed
@mohdsayed mohdsayed deleted the enhancements/topics-ee branch December 11, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants