Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Cookie Landing page - Part-1 #94

Merged
merged 4 commits into from
Aug 2, 2023

Conversation

mohdsayed
Copy link
Collaborator

@mohdsayed mohdsayed commented Aug 1, 2023

Description

Introduce design-system directory for common components, theme, etc.

Relevant Technical Choices

  • Refactor code to move some components used in Popup to design-system
  • Add tests coverage
  • Create stories.
  • Rearrange stories in the storybook.

Testing Instructions

Additional Information:

Screenshot/Screencast


Partially addresses #66

@mohdsayed mohdsayed self-assigned this Aug 2, 2023
@mohdsayed mohdsayed marked this pull request as ready for review August 2, 2023 02:39
@mohdsayed mohdsayed requested review from ayushnirwal and mayan-000 and removed request for ayushnirwal August 2, 2023 02:39
Copy link
Collaborator

@mayan-000 mayan-000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mohdsayed mohdsayed merged commit c655185 into develop Aug 2, 2023
@mohdsayed mohdsayed deleted the feat/cookies-landing-page-1 branch August 2, 2023 05:46
@mohdsayed mohdsayed changed the title Feature: Cookie Landing page - Part -1 Feature: Cookie Landing page - Part-1 Aug 4, 2023
@mohdsayed mohdsayed mentioned this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants