correctly error out when threshold is not met - fixes #48

GoogleChromeLabs · Feb 8, 2015 · e85c57e · e85c57e
1 parent b6c9b6b
commit e85c57e
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -51,7 +51,13 @@ module.exports.output = function (url, opts, cb) {
       return;
     }
 
-    output(handleOpts(url, opts), data);
+    try {
+      output(handleOpts(url, opts), data);
+    } catch (err) {
+      cb(err);
+      return;
+    }
+
     cb();
   });
 };
diff --git a/lib/output.js b/lib/output.js
@@ -70,5 +70,6 @@ module.exports = function (parameters, response) {
   if (response.score < threshold) {
     var err = new Error('Threshold of ' + threshold + ' not met with score of ' + response.score);
     err.noStack = true;
+    throw err;
   }
 };
diff --git a/test/test.js b/test/test.js
@@ -35,6 +35,12 @@ describe('Formatting', function () {
     output({strategy: 'desktop', format: 'json'}, response);
     assert(/"Score": 88/.test(chalk.stripColor(this.formattedOutput)));
   });
+
+  it('should throw when threshold is not met', function () {
+    assert.throws(function () {
+      output({threshold: 100}, response);
+    });
+  });
 });
 
 describe('API', function () {