Fix issue 115 "Cannot read property 'type' of undefined" #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re-optimizing-test
- Removed call to api. - Added test to options handler instead
- Merge branch 'feature-optimizing-test' of https://github.com/JuanMaRuiz/psi into feature-optimizing-test - Removed api-response-test
…iz/psi into feature-optimizing-test
Co-Authored-By: Shane Exterkamp <shaneexterkamp5@gmail.com>
Co-Authored-By: Shane Exterkamp <shaneexterkamp5@gmail.com>
* Add new condition to opportunityRules method to avoid failure when a rules does not have details property
exterkamp
approved these changes
Sep 3, 2020
| @@ -59,7 +59,7 @@ const opportunities = lighthouseResult => { | |||
|
|
|||
| const opportunityRules = rules.filter(rule => { | |||
| const {details} = audits[rule.id]; | |||
| return details.type === 'opportunity' && details.overallSavingsMs > 0; | |||
| return Boolean(details) && details.type === 'opportunity' && details.overallSavingsMs > 0; | |||
There was a problem hiding this comment.
I'm a double ! guy, but this wfm 👍
It seems that now is working properly. |
This was referenced Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new condition to
opportunityRulesmethod to avoid failure when a rules does not have details propertyfixes: #115