Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code review for two-up, pinch-zoom, trackDragging #11

Closed
wants to merge 31 commits into from
Closed

Code review for two-up, pinch-zoom, trackDragging #11

wants to merge 31 commits into from

Commits on Mar 9, 2018

  1. Very basic mouse move

    @jakearchibald
    jakearchibald committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    c37a4c2 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2018

  1. Pinch & pan

    @jakearchibald
    jakearchibald committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    99cf427 View commit details
    Browse the repository at this point in the history

  2. Supporting pointer events

    @jakearchibald
    jakearchibald committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    860f793 View commit details
    Browse the repository at this point in the history

  3. Avoiding 'as'

    @jakearchibald
    jakearchibald committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    dde466b View commit details
    Browse the repository at this point in the history

  4. Adding change event & method to set position. Including side-by-side … 

    …demo.
    @jakearchibald
    jakearchibald committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    464a414 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2018

  1. Updating demo

    @jakearchibald
    jakearchibald committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    7c6b668 View commit details
    Browse the repository at this point in the history

  2. Splitting pointer handling into library

    @jakearchibald
    jakearchibald committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    d463649 View commit details
    Browse the repository at this point in the history

  3. Fixing Safari & Edge event issues

    @jakearchibald
    jakearchibald committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    5600e4c View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2018

  1. Switching pointer tracking to a class-based API

    @jakearchibald
    jakearchibald committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    05fc027 View commit details
    Browse the repository at this point in the history

  2. Minor docs improvement

    @jakearchibald
    jakearchibald committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    4a324ad View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2018

  1. Complying with semistandard

    @jakearchibald
    jakearchibald committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    a6fb4fe View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2018

  1. More semi-standard

    @jakearchibald
    jakearchibald committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    a0fb0ab View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2018

  1. Two-up MVP

    @jakearchibald
    jakearchibald committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    abfeca6 View commit details
    Browse the repository at this point in the history

  2. Tslint complains about this, but it's required else it's tree-shaken.

    @jakearchibald
    jakearchibald committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    7d483c6 View commit details
    Browse the repository at this point in the history

  3. Performance tweak

    @jakearchibald
    jakearchibald committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    e17c844 View commit details
    Browse the repository at this point in the history

  4. Restoring event retargeting

    @jakearchibald
    jakearchibald committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    4702b6c View commit details
    Browse the repository at this point in the history

  5. Stub for multi-panel

    @jakearchibald
    jakearchibald committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    d137136 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2018

  1. Ooops

    @jakearchibald
    jakearchibald committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    c62d36a View commit details
    Browse the repository at this point in the history

  2. Using custom properties

    @jakearchibald
    jakearchibald committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    bb17890 View commit details
    Browse the repository at this point in the history

  3. Adding wheel support to pinch-zoom

    @jakearchibald
    jakearchibald committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    fe69cc6 View commit details
    Browse the repository at this point in the history

  4. Pinch-zoom: locking to bounds, the wrong way. 

    This is the wrong way to do this for Smoosh, but it'll be a valid option for others, so I'm recording it in this commit for now.
    @jakearchibald
    jakearchibald committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    839d9a2 View commit details
    Browse the repository at this point in the history

  5. Pinch-zoom: fixing scroll-to-zoom for Firefox 'lines' delta mode.

    @jakearchibald
    jakearchibald committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    530a58e View commit details
    Browse the repository at this point in the history

  6. Pinch-zoom: Changing bounds so it can't go further outside the bounds

    @jakearchibald
    jakearchibald committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    a2710e8 View commit details
    Browse the repository at this point in the history

  7. Pinch-zoom: Make clamping work if inner element is a different size t… 

    …o pinch-zoom
    @jakearchibald
    jakearchibald committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    c1d72ff View commit details
    Browse the repository at this point in the history

  8. Rename pointer tracker file

    @jakearchibald
    jakearchibald committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    9a86f96 View commit details
    Browse the repository at this point in the history

  9. Edge fallback for two-up

    @jakearchibald
    jakearchibald committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    5afeb51 View commit details
    Browse the repository at this point in the history

  10. Safari performance bottleneck fix.

    @jakearchibald
    jakearchibald committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    644340f View commit details
    Browse the repository at this point in the history

  11. Changes following review

    @jakearchibald
    jakearchibald committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    6292fa0 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2018

  1. Moving bounds checking into setTransform, and making this the main po… 

    …int of changing transforms.
    @jakearchibald
    jakearchibald committed Apr 3, 2018
    Configuration menu
    Copy the full SHA
    c4b3d4c View commit details
    Browse the repository at this point in the history

  2. Minor changes from feedback

    @jakearchibald
    jakearchibald committed Apr 3, 2018
    Configuration menu
    Copy the full SHA
    4d796bd View commit details
    Browse the repository at this point in the history

  3. Using dict for all setTransform params to improve readability

    @jakearchibald
    jakearchibald committed Apr 3, 2018
    Configuration menu
    Copy the full SHA
    7ddd714 View commit details
    Browse the repository at this point in the history