Options UI #135
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| import { h, Component } from 'preact'; | ||
| import * as prettyBytes from 'pretty-bytes'; | ||
|
|
||
| type FileContents = ArrayBuffer | Blob; | ||
|
|
||
| interface Props extends Pick<JSX.HTMLAttributes, Exclude<keyof JSX.HTMLAttributes, 'data'>> { | ||
|
There was a problem hiding this comment. Would it be simpler to just rename data rather than messing with types? There was a problem hiding this comment.
There was a problem hiding this comment. Yeah that seems fine |
||
| file?: FileContents; | ||
| compareTo?: FileContents; | ||
| increaseClass?: string; | ||
| decreaseClass?: string; | ||
| } | ||
|
|
||
| interface State { | ||
| size?: number; | ||
| sizeFormatted?: string; | ||
| compareSize?: number; | ||
| compareSizeFormatted?: string; | ||
| } | ||
|
|
||
| function calculateSize(data: FileContents): number { | ||
| return data instanceof ArrayBuffer ? data.byteLength : data.size; | ||
| } | ||
|
|
||
| export default class FileSize extends Component<Props, State> { | ||
| constructor(props: Props) { | ||
| super(props); | ||
| if (props.file) { | ||
| this.computeSize('size', props.file); | ||
| } | ||
| if (props.compareTo) { | ||
| this.computeSize('compareSize', props.compareTo); | ||
| } | ||
| } | ||
|
|
||
| componentWillReceiveProps({ file, compareTo }: Props) { | ||
| if (file !== this.props.file) { | ||
| this.computeSize('size', file); | ||
| } | ||
| if (compareTo !== this.props.compareTo) { | ||
| this.computeSize('compareSize', compareTo); | ||
| } | ||
| } | ||
|
|
||
| componentDidMount() { | ||
| this.applyStyles(); | ||
| } | ||
|
|
||
| componentDidUpdate() { | ||
| this.applyStyles(); | ||
| } | ||
|
|
||
| applyStyles() { | ||
| const { size, compareSize = 0 } = this.state; | ||
| if (size != null && this.base) { | ||
| const delta = size && compareSize ? (size - compareSize) / compareSize : 0; | ||
| this.base.style.setProperty('--size', '' + size); | ||
| this.base.style.setProperty('--size-delta', '' + Math.round(Math.abs(delta * 100))); | ||
| } | ||
| } | ||
|
|
||
| computeSize(prop: keyof State, data?: FileContents) { | ||
| const size = data ? calculateSize(data) : 0; | ||
| const pretty = prettyBytes(size); | ||
| this.setState({ | ||
| [prop]: size, | ||
| [prop + 'Formatted']: pretty, | ||
| }); | ||
| } | ||
|
|
||
| render( | ||
| { file, compareTo, increaseClass, decreaseClass, ...props }: Props, | ||
| { size, sizeFormatted = '', compareSize }: State, | ||
| ) { | ||
| const delta = size && compareSize ? (size - compareSize) / compareSize : 0; | ||
| return ( | ||
| <span {...props}> | ||
| {sizeFormatted} | ||
| {compareTo && ( | ||
| <span class={delta > 0 ? increaseClass : decreaseClass}> | ||
| {delta > 0 && '+'} | ||
| {Math.round(delta * 100)}% | ||
| </span> | ||
| )} | ||
| </span> | ||
| ); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't animate anything that involves layouts or paints unless we have no alternative. Are we currently using drop-valid and drop-invalid? I don't think we can detect that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, it looks like the background-color and border-color animations are removed in cases that the background or border actually changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm - maybe try it out? Without the step animation, the overlay's "exit" animation changes to the wrong color immediately. Are stepped transitions still problematic for jank? It doesn't seem like they should be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh gotcha. I misinterpreted this. We might drop the colours for drop valid/invalid (we can't properly tell what's valid or not anyay), but that's for another PR.