-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design review fixes #172
Design review fixes #172
Conversation
I can't remember the staging URL, do you have one for me to take a look at? |
A couple of points;
index.tsx:208 Error: RuntimeError: float unrepresentable in integer range |
c4cfc9b
to
e2f338c
Compare
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
There are a few cross-browser issues here, but I'm going to merge this and do a full UI review. |
* Design review fixes * Adding styles for mozjpeg & fixing some merge errors
Fixes the style issues from #143 (except button colors, which relies on stuff not on the
custom-range-inputs
branch).