Handle vectors #187
Handle vectors #187
Conversation
|
Hold on this, GitHub only showed me a subset of changes lol |
src/codecs/resize/resize.ts
Outdated
| const endAspect = dw / dh; | ||
|
|
||
| if (endAspect > currentAspect) { | ||
| const newSh = dh / (dw / sw); |
There was a problem hiding this comment.
I think with some shuffling, we can make the math a bit more “obvious”:
dh / (dw/sw) = sw * dh / dw = sw/endAspect
WDYT?
There was a problem hiding this comment.
I'm not sure what's going on there, but it's definitely an invalid left-hand assignment. What am I missing?
There was a problem hiding this comment.
Ohhh you mean change to sw / endAspect! I see now
There was a problem hiding this comment.
Lol sorry. I am suggesting to use the expression on the very right and showing how I got there. This is not supposed to be JavaScript, just math :D My bad.
There was a problem hiding this comment.
... GitHub really needs to fix their stupid code-review UI to update when someone comments.
src/codecs/resize/resize.ts
Outdated
| return { sw, sh: newSh, sx: 0, sy: newSy }; | ||
| } | ||
|
|
||
| const newSw = dw / (dh / sh); |
There was a problem hiding this comment.
Same trick here:
dw / (dh / sh) = sh * dw / dh = sh * endAspect
|
One thing I just noticed (when testing the Vector-aware resize works great, but the source image doesn’t incorporate zoom. So if I “resize” the squoosh logo SVG at 4000x4000, the output image will appear sharper than the original. Do we wanna do something about that?
|
|
Ahh, so the idea would be that the SVG stays sharp when scaled, but the compressed version is pixels? I can take a swing at that. |
|
Yeah, I guess we should prevent rasterizing at every zoom interaction, but maybe we can rasterize at 200% once zoom is above 100%, rasterize at 400% once zoom is above 200% or something along those lines? |
|
I think we get it for free if I add the |
|
Happy to leave this as a stretch goal. (aka punt to a separate, future PR) |
|
Filed #190 for the sharpness thing. I agree it's worth doing. |
I also made the resizer vector-aware, so you can resize the image larger & stay sharp.
jakearchibald
force-pushed
the
handle-vectors
branch
from
52c9438
to
28c6c61
Compare
* Allow loading SVG. Fixes GoogleChromeLabs#138. I also made the resizer vector-aware, so you can resize the image larger & stay sharp. * Handling SVG without width/height set. * Simplifying maths * Doh, case sensitive
DO NOT MERGE but please review (not based on master)
No longer fails when loading SVG.
Also, I made the resize preprocessor vector-aware, so it'll do the resizing in SVG if the source is SVG.