Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecs cleanup #189

Merged
merged 7 commits into from
Oct 12, 2018
Merged

Codecs cleanup #189

merged 7 commits into from
Oct 12, 2018

Conversation

surma
Copy link
Collaborator

@surma surma commented Oct 11, 2018

Closes #160
Closes #162

  • Properly containerize all wasm bits (you should all be able to build the codecs now if you have Docker installed)
  • Switch all codecs to -Os
  • Remove old build targets from top-level package.json

@jakearchibald
Copy link
Collaborator

Just tried building imageqaunt on this branch and my output looks very different. It might be asm.js? Is there something I need to do to update the docker container? If so, should that be part of the install script?

@surma
Copy link
Collaborator Author

surma commented Oct 11, 2018

Do you have a super old version of the container image? emcc switch to wasm-by-default at some point during squoosh so I stopped passing -s WASM=1.

Run docker pull trzeci/emscripten to update and try again plz?

@jakearchibald
Copy link
Collaborator

That did the trick. Is it worth adding docker pull trzeci/emscripten as a postinstall?

@surma
Copy link
Collaborator Author

surma commented Oct 11, 2018

An update is usually around 500MB. Not sure I wanna force that onto everyone automatically.

@jakearchibald
Copy link
Collaborator

What about a warning if trzeci/emscripten is out of date?

@surma
Copy link
Collaborator Author

surma commented Oct 11, 2018

I’ll look into that

@jakearchibald
Copy link
Collaborator

I've now built all the codecs and got the same results as the stuff checked in \o/

@surma
Copy link
Collaborator Author

surma commented Oct 11, 2018

It’s actually surprisingly hard. I can’t find a way to check for a new version on the Docker Hub. Can we punt on the check?

@jakearchibald
Copy link
Collaborator

I'll settle for outputting "Did you remember to docker pull trzeci/emscripten??" at the end of each build, and create an issue to figure out something better.

Given that we're running this & checking in the result, it feels important to remind people to do that step.

@surma
Copy link
Collaborator Author

surma commented Oct 12, 2018

@jakearchibald Done :)

@jakearchibald jakearchibald merged commit 577c77c into master Oct 12, 2018
@jakearchibald jakearchibald deleted the codecs-cleanup branch October 12, 2018 09:53
alisaitbilgi pushed a commit to alisaitbilgi/squoosh that referenced this pull request Feb 19, 2019
* Update imagequant processor

* Update mozjpeg encoder

* Update optipng encoder

* Update webp decoder

* Update webp encoder

* Remove old codec build tasks

* Add warning about docker image updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants