-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codecs cleanup #189
Codecs cleanup #189
Conversation
Just tried building imageqaunt on this branch and my output looks very different. It might be asm.js? Is there something I need to do to update the docker container? If so, should that be part of the install script? |
Do you have a super old version of the container image? emcc switch to wasm-by-default at some point during squoosh so I stopped passing Run |
That did the trick. Is it worth adding |
An update is usually around 500MB. Not sure I wanna force that onto everyone automatically. |
What about a warning if |
I’ll look into that |
I've now built all the codecs and got the same results as the stuff checked in \o/ |
It’s actually surprisingly hard. I can’t find a way to check for a new version on the Docker Hub. Can we punt on the check? |
I'll settle for outputting "Did you remember to Given that we're running this & checking in the result, it feels important to remind people to do that step. |
@jakearchibald Done :) |
* Update imagequant processor * Update mozjpeg encoder * Update optipng encoder * Update webp decoder * Update webp encoder * Remove old codec build tasks * Add warning about docker image updates
Closes #160
Closes #162
-Os