Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Options UI #39

Merged
merged 40 commits into from
Jun 29, 2018
Merged

Options UI #39

merged 40 commits into from
Jun 29, 2018

Commits on Jun 28, 2018

  1. Initial work to add Options config

    @developit @jakearchibald
    developit authored and jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    a2bec39 View commit details
    Browse the repository at this point in the history

  2. Use a single encoder instance and retry up to 10 times on failure.

    @developit @jakearchibald
    developit authored and jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    837e38a View commit details
    Browse the repository at this point in the history

  3. Switch both sides to allow encoding from the source image, add option… 

    …s configuration for each.
    @developit @jakearchibald
    developit authored and jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    64eb3f9 View commit details
    Browse the repository at this point in the history

  4. Styling for options (and a few tweaks for the app)

    @developit @jakearchibald
    developit authored and jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    22ef181 View commit details
    Browse the repository at this point in the history

  5. Dep updates.

    @developit @jakearchibald
    developit authored and jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    8b73be0 View commit details
    Browse the repository at this point in the history

  6. Remove commented out code.

    @developit @jakearchibald
    developit authored and jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    25c0805 View commit details
    Browse the repository at this point in the history

  7. Fix Encoder typing

    @developit @jakearchibald
    developit authored and jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    59a3517 View commit details
    Browse the repository at this point in the history

  8. Fix lint issues

    @developit @jakearchibald
    developit authored and jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    06e4483 View commit details
    Browse the repository at this point in the history

  9. Apparently I didnt have tslint autofix enabled on the chromebook

    @developit @jakearchibald
    developit authored and jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    bb4ac4c View commit details
    Browse the repository at this point in the history

  10. Attempt to fix layout/panning issues

    @developit @jakearchibald
    developit authored and jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    4d4d9b1 View commit details
    Browse the repository at this point in the history

  11. Fix missing custom element import!

    @developit @jakearchibald
    developit authored and jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    70d2927 View commit details
    Browse the repository at this point in the history

  12. Fix variable naming, remove dynamic encoder names, remove retry, allo… 

    …w encoders to return ImageData.
    @developit @jakearchibald
    developit authored and jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    e3ca13c View commit details
    Browse the repository at this point in the history

  13. Refactor state management to use an Array of objects and immutable up… 

    …dates instead of relying on explicit update notifications.
    @developit @jakearchibald
    developit authored and jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    b069c7f View commit details
    Browse the repository at this point in the history

  14. Add Identity encoder, which is a passthrough encoder that handles the… 

    … "original" view.
    @developit @jakearchibald
    developit authored and jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    d4c4ae4 View commit details
    Browse the repository at this point in the history

  15. Drop comlink-loader into the project and add ".worker" to the jpeg en… 

    …coder filename so it runs in a worker (:unicorn:)
    @developit @jakearchibald
    developit authored and jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    7d136db View commit details
    Browse the repository at this point in the history

  16. lint fixes.

    @developit @jakearchibald
    developit authored and jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    11e6197 View commit details
    Browse the repository at this point in the history

  17. cleanup

    @developit @jakearchibald
    developit authored and jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    13cac89 View commit details
    Browse the repository at this point in the history

  18. smaller PR feedback fixes

    @developit @jakearchibald
    developit authored and jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    9776670 View commit details
    Browse the repository at this point in the history

  19. rename "jpeg" codec to "MozJpeg"

    @developit @jakearchibald
    developit authored and jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    820d6f5 View commit details
    Browse the repository at this point in the history

  20. Formatting fixes for Options

    @developit @jakearchibald
    developit authored and jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    8e7d468 View commit details
    Browse the repository at this point in the history

  21. Colocate codecs and their options UIs in src/codecs, and standardize … 

    …the namings
    @developit @jakearchibald
    developit authored and jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    148faa8 View commit details
    Browse the repository at this point in the history

  22. Handle canvas errors

    @developit @jakearchibald
    developit authored and jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    c21413a View commit details
    Browse the repository at this point in the history

  23. Throw if quality is undefined, add default quality

    @developit @jakearchibald
    developit authored and jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    8e27c5e View commit details
    Browse the repository at this point in the history

  24. add note about temp styles

    @developit @jakearchibald
    developit authored and jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    e83628a View commit details
    Browse the repository at this point in the history

  25. add note about temp styles [2]

    @developit @jakearchibald
    developit authored and jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    e7fce7d View commit details
    Browse the repository at this point in the history

  26. Renaming updateOption

    @jakearchibald
    jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    b4ea56f View commit details
    Browse the repository at this point in the history

  27. Clarify option input bindings

    @developit @jakearchibald
    developit authored and jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    d85218a View commit details
    Browse the repository at this point in the history

  28. Move updateCanvas() to util and rename to drawBitmapToCanvas

    @developit @jakearchibald
    developit authored and jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    984b5fe View commit details
    Browse the repository at this point in the history

  29. use generics to pass through encoder options

    @developit @jakearchibald
    developit authored and jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    62fa05d View commit details
    Browse the repository at this point in the history

  30. Remove unused dependencies

    @developit @jakearchibald
    developit authored and jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    9fffc2a View commit details
    Browse the repository at this point in the history

  31. fix options type

    @developit @jakearchibald
    developit authored and jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    f1cbd26 View commit details
    Browse the repository at this point in the history

  32. const

    @developit @jakearchibald
    developit authored and jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    453e315 View commit details
    Browse the repository at this point in the history

  33. Use Array.prototype.some() for image loading check

    @developit @jakearchibald
    developit authored and jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    da6d1c4 View commit details
    Browse the repository at this point in the history

  34. Display encoding errors in the UI.

    @developit @jakearchibald
    developit authored and jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    a7f53ed View commit details
    Browse the repository at this point in the history

  35. I fought typescript and I think I won

    @jakearchibald
    jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    d618310 View commit details
    Browse the repository at this point in the history

  36. This doesn't need to be optional

    @jakearchibald
    jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    3ee32c9 View commit details
    Browse the repository at this point in the history

  37. Quality isn't optional

    @jakearchibald
    jakearchibald committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    3d3034f View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2018

  1. Simplifying comlink casting

    @jakearchibald
    jakearchibald committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    d0ad2b2 View commit details
    Browse the repository at this point in the history

  2. Splitting counters into loading and displaying

    @jakearchibald
    jakearchibald committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    c94e6dc View commit details
    Browse the repository at this point in the history

  3. Still loading if the loading counter isn't equal.

    @jakearchibald
    jakearchibald committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    cbd84d3 View commit details
    Browse the repository at this point in the history