More thorough hash removal #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfulton26
approved these changes
May 14, 2021
There was a problem hiding this comment.
yes, that looks right to me; what do you think @kirill578? thank you @jeffposnick
|
Thank you very much @mfulton26 for reporting issue #31 which I obviously did not notice when providing pull request #17. Thank you very much @jeffposnick for this improvement! |
|
#17 was a good improvement; I'm glad you found that one too. It caused our app to not work offline for a bit because our app loading with a hash initially so it didn't get cached properly but we were able to remove the hash for the initial load as a workaround and I think with this fix that won't be necessary anymore. Teamwork! 😄 |
kirill578
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please let me know if this is what you had in mind, @mfulton26.
Also CC: @arneschuldt who implemented a related change in this library previously.
Fixes #31