Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature detection for Multiple Memories proposal #70

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Sep 21, 2023

We try to instantiate a module that defines two memories. If multiple memories is implemented, this will succeed but otherwise it throws an error like

CompileError: the number of memories must be at most one

We try to instantiate a module that defines two memories. If multiple
memories is implemented, this will succeed but otherwise it throws an
error like
```
CompileError: the number of memories must be at most one
```
Copy link
Member

@tomayac tomayac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approval

@tomayac tomayac merged commit dc1d3e0 into GoogleChromeLabs:main Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants