Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plugins option #17

Merged
merged 2 commits into from
Dec 14, 2018
Merged

Add plugins option #17

merged 2 commits into from
Dec 14, 2018

Conversation

3846masa
Copy link
Contributor

@3846masa 3846masa commented Dec 6, 2018

Implemented #16

[
  new WorkerPlugin({
    plugins: [new SomePluginInWorker()],
  }),
]
// Or
[
  new SomePluginInWorkerAndBrowser(),
  new WorkerPlugin({
    plugins: ['SomePluginInWorkerAndBrowser'],
  }),
]

developit
developit approved these changes Dec 14, 2018
View reviewed changes
Copy link
Collaborator

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a wonderful solution! Thank you so much for putting in the work to get tests around it too 💖

src/symbol.js
* the License.
*/

const WORKER_PLUGIN_SYMBOL = Symbol('WORKER_PLUGIN_SYMBOL');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth using Symbol.for() here.

@developit developit merged commit 4454968 into GoogleChromeLabs:master Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developit developit developit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@3846masa @developit