Only warn about dynamic module workers #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the "new Worker() will only be bundled if passed a String" warning in cases where `new Worker()` is not called with `{type:'module'}`. It's possible this will result in folks not realizing their Worker is being left unbundled when type:module isn't used.
|
@developit hi, any progress on this? |
|
@developit thank you :) |
|
@developit Thank you so much! Do you have a plan to release any time soon? |
|
Can a new release be created so we can get this fix? Thanks! |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the "new Worker() will only be bundled if passed a String" warning in cases where
new Worker()is not called with{type:'module'}. It's possible this will result in folks not realizing their Worker is being left unbundled when type:module isn't used.This should fix #12.