Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webpack 5 compatibility #84

Merged
merged 1 commit into from
Jul 4, 2020
Merged

Webpack 5 compatibility #84

merged 1 commit into from
Jul 4, 2020

Conversation

gluck
Copy link
Contributor

@gluck gluck commented Jun 27, 2020

  • FetchCompileWasmTemplatePlugin has been renamed
  • Array changed into Set

developit
developit approved these changes Jul 4, 2020
View reviewed changes
Copy link
Collaborator

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@developit developit merged commit f6b1b4f into GoogleChromeLabs:master Jul 4, 2020
@balloob
Copy link

balloob commented Jul 11, 2020

@gluck I tried this PR and I still get one issue. Did you see this too?

TypeError: ParserHelpers.addParsedVariableToModule is not a function
        at /home/paulus/dev/hass/frontend/build-scripts/webpack-plugins/worker-plugin.js:171:27

@gluck
Copy link
Contributor Author

gluck commented Jul 15, 2020

@balloob I didn't encounter this error (because of my setup ?), but it does seem that this method was removed, so usage should be reviewed.

@gluck gluck deleted the webpack5 branch July 15, 2020 09:55
@balloob balloob mentioned this pull request Aug 12, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developit developit developit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gluck @balloob @developit