-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impact of third-party render blocking scripts #33
Open
mukeshpanchal27
wants to merge
4
commits into
main
Choose a base branch
from
add/30-third-party-render-blocking-script-query
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
fcc3e99
Impact of third-party render blocking scripts
mukeshpanchal27 8087457
Address review feedback
mukeshpanchal27 60bdae8
Merge main branch changes
mukeshpanchal27 d0aa092
Merge branch 'main' into add/30-third-party-render-blocking-script-query
mukeshpanchal27 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
# HTTP Archive query to measure the usage of third-party render blocking scripts for WordPress sites. | ||
# | ||
# WPP Research, Copyright 2023 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# https://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
# See query results here: https://github.com/GoogleChromeLabs/wpp-research/pull/33 | ||
SELECT | ||
percentile, | ||
client, | ||
host, | ||
APPROX_QUANTILES(requests, 1000)[OFFSET(percentile * 10)] AS num_requests | ||
FROM ( | ||
SELECT | ||
client, | ||
page, | ||
IF | ||
(NET.HOST(requests.url) IN ( | ||
SELECT | ||
domain | ||
FROM | ||
`httparchive.almanac.third_parties` | ||
WHERE | ||
date = '2022-06-01' | ||
AND category != 'hosting' ), 'third party', 'first party') AS host, | ||
COUNT(0) AS requests | ||
FROM | ||
`httparchive.almanac.requests` AS requests | ||
JOIN | ||
`httparchive.pages.2022_06_01_*` AS pages | ||
ON | ||
pages.url = requests.page | ||
WHERE | ||
date = '2022-06-01' | ||
AND type = 'script' | ||
AND JSON_EXTRACT(pages.payload, '$._detected_apps.WordPress') IS NOT NULL | ||
AND CAST(JSON_EXTRACT( pages.payload, '$._renderBlockingJS') AS INT64) > 0 | ||
GROUP BY | ||
client, | ||
page, | ||
host), | ||
UNNEST([10, 25, 50, 75, 90, 100]) AS percentile | ||
GROUP BY | ||
percentile, | ||
client, | ||
host | ||
ORDER BY | ||
client, | ||
percentile, | ||
host |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mukeshpanchal27 I am convinced this query will return the distribution of all the third parties and first parties (both render blocking and non-render blocking) for a site with at least one render-blocking script.
This won't return the distribution of render-blocking third-party and render-blocking first-party scripts.
Please find my explanation and example in this comment
I am finding it hard to explain in this PR.
cc: @felixarntz