Enhance benchmark-web-vitals command with additional metrics
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #40: The initial version of the
benchmark-web-vitalscommand only comes with load time metrics, since other metrics are a bit more complicated to capture in a headless browser request, e.g. CLS and INP require interactions to happen and capture events throughout the page lifecycle, not just load time related.This is an early draft intended for iteration in the future.
You can already test this branch, but you will likely notice that you don't get data for CLS and INP for the reason outlined above (and each request will take ~30s as that it when Puppeteer will time out by default). Before this PR can be completed and merged, we will have to figure out how to trigger those metrics to be measured and exposed using the https://github.com/GoogleChrome/web-vitals library that is being used.