Set up Bazel build system to outsource parameterization #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medb
requested changes
Oct 14, 2019
medb
requested changes
Oct 15, 2019
medb
requested changes
Oct 17, 2019
medb
requested changes
Oct 18, 2019
medb
requested changes
Oct 18, 2019
|
/gcbrun |
…y parameter configurations through the command line or through BUILD file args.
… tests to take an image_version flag that is generalized to all our tests when specified.
…inherited by all our init actions
…g constraints. Install and run Bazel on presubmit.
medb
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows us to run tests from the command line with specific configurations that developers might want to test. Example: bazel test solr:test_solr --test_arg=--params="SINGLE 1.3 m" --test_arg=--params="STANDARD 1.2 m"
If no params are specified, then the default set of configurations is used.
More details here: https://docs.google.com/document/d/1-NXCdXnJ7RnORiZu2nN05xf3kUomFQruJKhqPNuL2n8/edit?usp=sharing