Implement at-least-once option that utilizes default stream #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
davidrabinowitz
assigned davidrabinowitz and agrawal-siddharth and unassigned davidrabinowitz
davidrabinowitz
requested changes
Jun 26, 2023
agrawal-siddharth
force-pushed
the
use_default_stream
branch
2 times, most recently
from
a5b0ad5
to
1c48241
Compare
|
Added an integration test to exercise the following scenarios with writeAtLeastOnce turned on: (a) append to a new file |
agrawal-siddharth
force-pushed
the
use_default_stream
branch
from
1c48241
to
015c4ed
Compare
agrawal-siddharth
force-pushed
the
use_default_stream
branch
from
015c4ed
to
95b81a6
Compare
davidrabinowitz
requested changes
Jul 7, 2023
...onnector-common/src/main/java/com/google/cloud/bigquery/connector/common/BigQueryClient.java
Outdated
Show resolved
Hide resolved
| @@ -208,6 +208,23 @@ public boolean deleteTable(TableId tableId) { | |||
| return bigQuery.delete(tableId); | |||
| } | |||
|
|
|||
| private Job buildQueryJob( | |||
| TableId temporaryTableId, | |||
There was a problem hiding this comment.
Should be sourceTableId
...onnector-common/src/main/java/com/google/cloud/bigquery/connector/common/BigQueryClient.java
Show resolved
Hide resolved
agrawal-siddharth
force-pushed
the
use_default_stream
branch
2 times, most recently
from
9a12708
to
ddcb019
Compare
|
/gcbrun |
agrawal-siddharth
force-pushed
the
use_default_stream
branch
from
ddcb019
to
469d279
Compare
|
/gcbrun |
1 similar comment
|
/gcbrun |
agrawal-siddharth
force-pushed
the
use_default_stream
branch
2 times, most recently
from
000429b
to
b7cb303
Compare
|
/gcbrun |
davidrabinowitz
requested changes
Jul 13, 2023
| } | ||
|
|
||
| protected void writeToBigQuery(Dataset<Row> df, SaveMode mode, String format) { | ||
| protected void writeToBigQuery(Dataset<Row> df, SaveMode mode, String writeAtLeastOnce) { | ||
| writeToBigQuery(df, mode, "avro", writeAtLeastOnce); |
There was a problem hiding this comment.
Please maintain the format and avoid overriding it - to maintain backward compatibility this should be
protected void writeToBigQuery(Dataset<Row> df, SaveMode mode, String format) {
writeToBigQuery(df, mode, format, "False");
}
| @@ -162,17 +162,23 @@ private StandardTableDefinition testPartitionedTableDefinition() { | |||
| } | |||
|
|
|||
| protected void writeToBigQuery(Dataset<Row> df, SaveMode mode) { | |||
| writeToBigQuery(df, mode, "avro"); | |||
| writeToBigQuery(df, mode, "False"); | |||
There was a problem hiding this comment.
replace with writeToBigQuery(df, mode, "avro", "False");
to support streaming scenarios in which small batches of data are written.
agrawal-siddharth
force-pushed
the
use_default_stream
branch
from
b7cb303
to
af17ebe
Compare
|
/gcbrun |
davidrabinowitz
approved these changes
Jul 13, 2023
This was referenced Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to support streaming scenarios in which small batches of data are written.