Issue #1254: fix getting partitioning fields for pseudo columns #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
davidrabinowitz
requested changes
Jul 12, 2024
There was a problem hiding this comment.
Can you please add an integration test based on issue #1254 ?
|
/gcbrun |
|
Added integration tests which fail as expected without the fix. |
davidrabinowitz
requested changes
Jul 15, 2024
...ommon/src/test/java/com/google/cloud/spark/bigquery/integration/ReadIntegrationTestBase.java
Show resolved
Hide resolved
|
/gcbrun |
1 similar comment
|
/gcbrun |
isha97
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When getting partitioning fields,
timePartitioning.getField()returns null when the table is ingestion time partitioned (partitioned by_PARTITIONTIMEOR_PARTITIONDATE).The change fixes this bug.