Encode snapshotTimeMillis in view materialization query #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isha97
requested changes
Jul 19, 2024
...-common/src/test/java/com/google/cloud/bigquery/connector/common/ReadSessionCreatorTest.java
Outdated
Show resolved
Hide resolved
|
/gcbrun |
isha97
approved these changes
Jul 22, 2024
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
snapshotTimeMillisdoes not currently make sense with views since the view is materialized to a table without taking this property into consideration, and then a read session is created attempting to read the materialized table at this timestamp (which has only just been created). This change will instead usesnapshotTimeMillisto addFOR SYSTEM_TIME AS OF TIMESTAMP_MILLISclause to the query that materializes the view to a table and the read session simply consumes that.