Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify dependency manager: remove unused code #2011

Merged

Conversation

fbiville
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 46.59%. Comparing base (9d39b07) to head (8516b2c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...oogle/cloud/teleport/v2/neo4j/utils/BeamBlock.java 0.00% 8 Missing ⚠️
...eleport/v2/neo4j/templates/GoogleCloudToNeo4j.java 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2011      +/-   ##
============================================
+ Coverage     46.58%   46.59%   +0.01%     
+ Complexity     3960     3959       -1     
============================================
  Files           869      869              
  Lines         51599    51574      -25     
  Branches       5403     5402       -1     
============================================
- Hits          24036    24033       -3     
+ Misses        25844    25822      -22     
  Partials       1719     1719              
Components Coverage Δ
spanner-templates 68.57% <ø> (ø)
spanner-import-export 65.57% <ø> (ø)
spanner-live-forward-migration 77.36% <ø> (ø)
spanner-live-reverse-replication 78.32% <ø> (ø)
spanner-bulk-migration 87.62% <ø> (ø)
Files with missing lines Coverage Δ
...eleport/v2/neo4j/templates/GoogleCloudToNeo4j.java 0.00% <0.00%> (ø)
...oogle/cloud/teleport/v2/neo4j/utils/BeamBlock.java 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@ali-ince ali-ince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice simplification 👍

@fbiville fbiville force-pushed the neo4j/beam-block-cleanup branch from 442c4bd to 4b0d74c Compare December 16, 2024 10:26
@fbiville fbiville force-pushed the neo4j/beam-block-cleanup branch from 4b0d74c to 75ed552 Compare January 7, 2025 15:48

Verified

This commit was signed with the committer’s verified signature.
simeonschaub Simeon David Schaub
@fbiville fbiville force-pushed the neo4j/beam-block-cleanup branch from 75ed552 to 8516b2c Compare January 8, 2025 10:22
@liferoad liferoad merged commit 7553c7f into GoogleCloudPlatform:main Jan 8, 2025
14 checks passed
pawankashyapollion pushed a commit to ollionorg/DataflowTemplates-fork that referenced this pull request Jan 10, 2025
akashthawaitcc pushed a commit to ollionorg/DataflowTemplates-fork that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants