Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SSL mode in embedded Cassandra used by unit tests. #2130

Conversation

VardhanThigle
Copy link
Contributor

Overview

This is a child of #2114.
This has UT only changes to enable SSL in embedded Cassandra used by Bulk UT.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.68%. Comparing base (f933ae9) to head (6ed1b5a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2130      +/-   ##
============================================
+ Coverage     46.62%   54.68%   +8.06%     
+ Complexity     3953     1574    -2379     
============================================
  Files           867      401     -466     
  Lines         51567    21725   -29842     
  Branches       5399     2156    -3243     
============================================
- Hits          24043    11881   -12162     
+ Misses        25808     9147   -16661     
+ Partials       1716      697    -1019     
Components Coverage Δ
spanner-templates 70.08% <ø> (+1.45%) ⬆️
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration 77.49% <ø> (ø)
spanner-live-reverse-replication 78.43% <ø> (ø)
spanner-bulk-migration 87.66% <ø> (ø)

see 483 files with indirect coverage changes

@Deep1998
Copy link
Contributor

Deep1998 commented Jan 13, 2025

Could we get a summary as a code comment of why all this is needed to enable SSL as readers may not be fully aware of the nuances of enabling SSL?

@VardhanThigle VardhanThigle force-pushed the existing-cassandra-io-ssl-in-ut branch from 1632f51 to 3b39d1f Compare January 13, 2025 12:50
@VardhanThigle
Copy link
Contributor Author

VardhanThigle commented Jan 13, 2025

Could we get a summary as a code comment of why all this is needed to enable SSL as readers may not be fully aware of the nuances of enabling SSL?
Thanks.
Added Java Docs. Although this is a UT only code, in this case JavaDocs are needed.
Let's syncp over a call if I could help with more details around the SSL enablements.

@VardhanThigle VardhanThigle force-pushed the existing-cassandra-io-ssl-in-ut branch from 3b39d1f to 6ed1b5a Compare January 13, 2025 12:54
@VardhanThigle VardhanThigle merged commit 9f8b54f into GoogleCloudPlatform:main Jan 14, 2025
14 checks passed
pawankashyapollion pushed a commit to ollionorg/DataflowTemplates-fork that referenced this pull request Jan 15, 2025
akashthawaitcc pushed a commit to ollionorg/DataflowTemplates-fork that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants